[io] Check whether a form still exists before resetting it #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IO clears the form content on end, but if the caller removed the form soon after it was called, this fails at a removeAttribute on part of the, now non-existent form content. We should check that the form exists before attempting to reset it.
|
👍 |
andrewnicols
added a commit
to andrewnicols/moodle
that referenced
this pull request
Dec 6, 2013
|
You rock. I'm going to cherry pick this into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IO clears the form content on end, but if the caller removed the form soon
after it was called, this fails at a removeAttribute on part of the, now
non-existent form content.
We should check that the form exists before attempting to reset it.
Fixes #1121